lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070912.063139.55741343.davem@davemloft.net> Date: Wed, 12 Sep 2007 06:31:39 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ebiederm@...ssion.com Cc: xemul@...nvz.org, kaber@...sh.net, netdev@...r.kernel.org, shemminger@...ux-foundation.org Subject: Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation. From: ebiederm@...ssion.com (Eric W. Biederman) Date: Wed, 12 Sep 2007 07:19:56 -0600 > > I was getting strange kernel crashes when attempting to > create veth devices when I did not specify a peer argument > to /bin/ip. > > So this patch defaults peer_tb to all zeros and doesn't attempt to > reuse the netlink attributes for the primary link to create the > secondary link and now I can't reproduce the failures. > > Given that some of the most interesting netlink attributes to specify > like a mac address or a network device name seem are generally > the wrong thing to do this seems like the right approach. > > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> This looks mostly fine, can someone else who knows veth a bit review this as well? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists