netdev - Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070912.235521.41654166.davem@davemloft.net>
Date:	Wed, 12 Sep 2007 23:55:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	auke-jan.h.kok@...el.com
Cc:	Robert.Olsson@...a.slu.se, akpm@...ux-foundation.org,
	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes
 from net-2.6.24.git

From: "Kok, Auke" <auke-jan.h.kok@...el.com>
Date: Wed, 12 Sep 2007 09:42:29 -0700

> David Miller wrote:
> > 
> > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> > index 7b0bcdb..58bb758 100644
> > --- a/drivers/net/e1000/e1000_main.c
> > +++ b/drivers/net/e1000/e1000_main.c
> > @@ -3944,7 +3944,7 @@ e1000_clean(struct napi_struct *napi, int budget)
> >  	                  &work_done, budget);
> >  
> >  	/* If no Tx and not enough Rx work done, exit the polling mode */
> > -	if ((tx_cleaned && (work_done < budget)) ||
> > +	if ((!tx_cleaned && (work_done < budget)) ||
> >  	   !netif_running(poll_dev)) {
> >  quit_polling:
> >  		if (likely(adapter->itr_setting & 3))
> 
> 
> Ack, this is exactly what I did to fix e1000e as well.

Thanks for reviewing.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html