lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Sep 2007 16:46:38 +0400 From: Evgeniy Polyakov <johnpol@....mipt.ru> To: Krishna Kumar <krkumar2@...ibm.com> Cc: herbert@...dor.apana.org.au, hadi@...erus.ca, kaber@...sh.net, shemminger@...ux-foundation.org, davem@...emloft.net, jagana@...ibm.com, Robert.Olsson@...a.slu.se, rick.jones2@...com, xma@...ibm.com, gaagaan@...il.com, kumarkr@...ux.ibm.com, rdreier@...co.com, peter.p.waskiewicz.jr@...el.com, mcarlson@...adcom.com, jeff@...zik.org, general@...ts.openfabrics.org, netdev@...r.kernel.org, tgraf@...g.ch, randy.dunlap@...cle.com, mchan@...adcom.com, sri@...ibm.com Subject: Re: [PATCH 2/10 REV5] [core] Add skb_blist & support for batching On Fri, Sep 14, 2007 at 02:31:37PM +0530, Krishna Kumar (krkumar2@...ibm.com) wrote: > @@ -3566,6 +3579,13 @@ int register_netdevice(struct net_device > } > } > > + if (dev->features & NETIF_F_BATCH_SKBS) { > + /* Driver supports batching skb */ > + dev->skb_blist = kmalloc(sizeof *dev->skb_blist, GFP_KERNEL); > + if (dev->skb_blist) > + skb_queue_head_init(dev->skb_blist); > + } > + A nitpick is that you should use sizeof(struct ...) and I think it requires flag clearing in cae of failed initialization? > /* > * nil rebuild_header routine, > * that should be never called and used as just bug trap. -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists