lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Sep 2007 10:57:08 +0200 (CEST) From: Jan Engelhardt <jengelh@...putergmbh.de> To: Stephen Hemminger <shemminger@...ux-foundation.org> cc: Emil Medve <Emilian.Medve@...escale.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, i2c@...sensors.org, linux-omap-open-source@...ux.omap.com Subject: Re: [PATCH] Move the definition of pr_err() into kernel.h On Sep 12 2007 12:59, Stephen Hemminger wrote: >> Other pr_*() macros are already defined in kernel.h, but pr_err() was defined >> multiple times in several other places >> >> Signed-off-by: Emil Medve <Emilian.Medve@...escale.com> > >pr_error seems better than pr_err > >Please add the full set: > pr_alert > pr_critical > pr_error > pr_warn > pr_notice I repeat to be totally against this. (1) You are trying to add pr_*(fmt, arg) as a lazy shorthand for printk(KERN_* fmt, arg...) and (2) do not seem to notice that pr_debug() changes its behavior depending on -DDEBUG, which pr_alert() etc. do not, so there is IMHO no point (that includes the already existing pr_info()). Why not just obsolete printk() altogether then? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists