lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Sep 2007 09:07:06 -0500 From: Steve Wise <swise@...ngridcomputing.com> To: Sean Hefty <mshefty@...ips.intel.com> CC: rdreier@...co.com, sean.hefty@...el.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, general@...ts.openfabrics.org Subject: Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts. Sean Hefty wrote: >> The iWARP driver must translate all listens on address 0.0.0.0 to the >> set of rdma-only ip addresses for the device in question. This prevents >> incoming connect requests to the TCP ipaddresses from going up the >> rdma stack. > > I've only given this a high level review at this point, and while the > patch looks okay on first pass, is there a way to move some of this > functionality to either the rdma_cm or iw_cm? I don't like the idea of > every iwarp driver having to implement address/listen list maintenance. > I may have some ideas after re-examining it. I think the translating of listen requests from 0.0.0.0->specific addresses could be moved to the iwcm... > >> Implementation Details: > > There are a couple of areas that I made a note to look at in more detail > (because I didn't understand everything that was happening), but I did > have one minor nit - most uses of list_del_init can just be list_del. > Ok. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists