netdev - Re: [ofa-general] [PATCH] RDMA/CMA: Use neigh_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Sep 2007 10:34:23 +0300
From:	Or Gerlitz <ogerlitz@...taire.com>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	Steve Wise <swise@...ngridcomputing.com>, rdreier@...co.com,
	sean.hefty@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, general@...ts.openfabrics.org
Subject: Re: [ofa-general] [PATCH] RDMA/CMA: Use neigh_event_send() to initiate
 neighbour discovery.

Steve Wise wrote:
> RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.
> 
> Calling arp_send() to initiate neighbour discovery (ND) doesn't do the
> full ND protocol.  Namely, it doesn't handle retransmitting the arp
> request if it is dropped. The function neigh_event_send() does all this.
> Without doing full ND, rdma address resolution fails in the presence of
> dropped arp bcast packets.

Jay,

Is there a way to deploy something similar for the gratuitous arp being 
sent by the bonding driver at bond_arp_send()?

We have seen rare situations where the skb was dropped by the stack and 
hence bonding fail-over was detected by the remote peer only when its 
neighboring subsystem probe failures dictated that a new arp must be issued.

Or.
> 
> Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
> ---
> 
>  drivers/infiniband/core/addr.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
> index c5c33d3..5381c80 100644
> --- a/drivers/infiniband/core/addr.c
> +++ b/drivers/infiniband/core/addr.c
> @@ -161,8 +161,7 @@ static void addr_send_arp(struct sockadd
>  	if (ip_route_output_key(&rt, &fl))
>  		return;
>  
> -	arp_send(ARPOP_REQUEST, ETH_P_ARP, rt->rt_gateway, rt->idev->dev,
> -		 rt->rt_src, NULL, rt->idev->dev->dev_addr, NULL);
> +	neigh_event_send(rt->u.dst.neighbour, NULL);
>  	ip_rt_put(rt);
>  }

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html