lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070916.161748.48388692.davem@davemloft.net> Date: Sun, 16 Sep 2007 16:17:48 -0700 (PDT) From: David Miller <davem@...emloft.net> To: krkumar2@...ibm.com Cc: johnpol@....mipt.ru, herbert@...dor.apana.org.au, hadi@...erus.ca, kaber@...sh.net, shemminger@...ux-foundation.org, jagana@...ibm.com, Robert.Olsson@...a.slu.se, rick.jones2@...com, xma@...ibm.com, gaagaan@...il.com, netdev@...r.kernel.org, rdreier@...co.com, peter.p.waskiewicz.jr@...el.com, mcarlson@...adcom.com, jeff@...zik.org, mchan@...adcom.com, general@...ts.openfabrics.org, kumarkr@...ux.ibm.com, tgraf@...g.ch, randy.dunlap@...cle.com, sri@...ibm.com Subject: Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000 From: Krishna Kumar <krkumar2@...ibm.com> Date: Fri, 14 Sep 2007 14:30:58 +0530 > This set of patches implements the batching xmit capability, and > adds support for batching in IPoIB and E1000 (E1000 driver changes > is ported, thanks to changes taken from Jamal's code from an old > kernel). The only major complaint I have about this patch series is that the IPoIB part should just be one big changeset. Otherwise the tree is not bisectable, for example the initial ipoib header file change breaks the build. The tree must compile and work properly after every single patch. On a lower priority, I question the indirection of skb_blist by making it a pointer. For what? Saving 12 bytes on 64-bit? That kmalloc()'d thing is a nearly guarenteed cache and/or TLB miss. Just inline the thing, we generally don't do crap like this anywhere else. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists