netdev - Re: [PATCH 2/7] [PPP] pppoe: Fix data clobbering in __pppoe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20070916.162004.18302485.davem@davemloft.net>
Date:	Sun, 16 Sep 2007 16:20:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	jchapman@...alix.com, mostrows@...akeasy.net, paulus@...ba.org,
	toralf.foerster@....de, netdev@...r.kernel.org
Subject: Re: [PATCH 2/7] [PPP] pppoe: Fix data clobbering in __pppoe_xmit
 and return value

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 31 Aug 2007 17:09:04 +0800

> [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value
> 
> The function __pppoe_xmit modifies the skb data and therefore it needs
> to copy and skb data if it's cloned.
> 
> In fact, it currently allocates a new skb so that it can return 0 in
> case of error without freeing the original skb.  This is totally wrong
> because returning zero is meant to indicate congestion whereupon pppoe
> is supposed to wake up the upper layer once the congestion subsides.
> 
> This makes sense for ppp_async and ppp_sync but is out-of-place for
> pppoe.  This patch makes it always return 1 and free the skb.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html