netdev - Re: [SKBUFF]: Fix up csum_start when head room changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070916.163319.105429760.davem@davemloft.net>
Date:	Sun, 16 Sep 2007 16:33:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [SKBUFF]: Fix up csum_start when head room changes

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sat, 1 Sep 2007 09:13:33 +0800

> Hi Dave:
> 
> [SKBUFF]: Fix up csum_start when head room changes
> 
> Thanks for noticing the bug where csum_start is not updated
> when the head room changes.
> 
> This patch fixes that.  It also moves the csum/ip_summed
> copying into copy_skb_header so that skb_copy_expand gets
> it too.  I've checked its callers and no one should be upset
> by this.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Herbert, thanks for following up on this.

Although this is technically a "bug fix" we don't have anyone
explicitly triggering this and I don't feel comfortable pushing this
into net-2.6 without a reported failure case right now.

So I applied it to net-2.6.24 for now.

If you disagree, plead your case :-)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html