lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ada7implyrj.fsf@cisco.com> Date: Mon, 17 Sep 2007 15:20:48 -0700 From: Roland Dreier <rdreier@...co.com> To: Jay Vosburgh <fubar@...ibm.com> Cc: netdev@...r.kernel.org, monis@...taire.com, monisonlists@...il.com, ogerlitz@...taire.com, jgarzik@...ox.com, davem@...emloft.net, general@...ts.openfabrics.org Subject: Re: [PATCH 04/11] IB/ipoib: Verify address handle validity on send Looks fine overall, with one minor nitpick: > - if (unlikely(memcmp(&neigh->dgid.raw, > + if (unlikely((memcmp(&neigh->dgid.raw, > skb->dst->neighbour->ha + 4, > - sizeof(union ib_gid)))) { > + sizeof(union ib_gid))) || > + (neigh->dev != dev))) { the indentation here makes this confusing to read -- I would just do: } else if (neigh->ah) { if (unlikely(memcmp(&neigh->dgid.raw, skb->dst->neighbour->ha + 4, - sizeof(union ib_gid)))) { + sizeof(union ib_gid)) || + neigh->dev != dev)) { - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists