lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <46EED670.60107@gmail.com> Date: Mon, 17 Sep 2007 21:33:04 +0200 From: Jiri Slaby <jirislaby@...il.com> To: "Kok, Auke" <auke-jan.h.kok@...el.com> CC: akpm@...ux-foundation.org, davem@...emloft.net, netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net, Robert.Olsson@...a.slu.se, jeff@...zik.org Subject: Re: [PATCH] [-MM, FIX V4] e1000e: incorporate napi_struct changes from net-2.6.24.git On 09/17/2007 06:29 PM, Kok, Auke wrote: > Jiri Slaby wrote: >> On 12/23/-28158 08:59 PM, Auke Kok wrote: >>> This incorporates the new napi_struct changes into e1000e. Included >>> bugfix for ifdown hang from Krishna Kumar for e1000. >>> >>> Disabling polling is no longer needed at init time, so remove >>> napi_disable() call from _probe(). >>> >>> This also fixes an endless polling loop where the driver signalled >>> "polling done" improperly back to the stack. >>> >>> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com> Tested-by: Jiri Slaby <jirislaby@...il.com> >>> --- >>> >>> drivers/net/e1000e/e1000.h | 2 ++ >>> drivers/net/e1000e/netdev.c | 40 ++++++++++++++++------------------------ >>> 2 files changed, 18 insertions(+), 24 deletions(-) [...] > I have no lockups here as well anymore, so I'm wondering if you accidentally used > V3 of the patch. And so am I, it works, I ported one change to e1000 (non-e) driver and missed the return 0; removal. Fixed both of them now, so one of them caused it. thanks a lot, -- Jiri Slaby (jirislaby@...il.com) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists