netdev - Re: [FIX NETLINK] properly check arguments to netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070918.145331.67883847.davem@davemloft.net>
Date:	Tue, 18 Sep 2007 14:53:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	holger@...eitzenberger.de
Cc:	netdev@...r.kernel.org
Subject: Re: [FIX NETLINK] properly check arguments to netlink_bind()

From: Holger Eitzenberger <holger@...eitzenberger.de>
Date: Tue, 18 Sep 2007 23:05:52 +0200

> Holger Eitzenberger <holger@...eitzenberger.de> writes:
> 
> > while going through going netlink code I found out that netlink_bind()
> > does not properly check bind parameters.  I checked both 2.6.23-rc1 as
> > well as 2.6.16.53, both are affected.
> >
> > With a small test prog I wasn't able to crash my maschine though, but
> > data was accessed out of bounds.
> 
> See my attached patch, thanks.

Your patch is incorrect and also unnecessary.

Firstly, you patch compares the address _pointer_ against
the minimum length.  That's obviously wrong.

And if you check the call sites of the protocol ->bind() methods, they
all use on-stack buffer for the address object which is at least
MAX_SOCK_ADDR bytes in length so that the bind methods don't have to
check the size if they don't want to.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html