netdev - Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46EFE3F5.5070201@tmr.com>
Date:	Tue, 18 Sep 2007 10:43:01 -0400
From:	Bill Davidsen <davidsen@....com>
To:	David Miller <davem@...emloft.net>
CC:	ytht.net@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in
   skb to reply packet

David Miller wrote:
> From: lepton <ytht.net@...il.com>
> Date: Tue, 18 Sep 2007 10:16:17 +0800
> 
>> Hi,
>>   In some situation, icmp_reply and ip_send_reply will send
>>   out packet with the wrong source addr, the following patch
>>   will fix this.
>>
>>   I don't understand why we must use rt->rt_src in the current
>>   code, if this is a wrong fix, please correct me.
>>
>> Signed-off-by: Lepton Wu <ytht.net@...il.com>
> 
> That the address is wrong is your opinion only :-)

Mine too, since an ICMP reply from an unexpected source IP is likely to 
be logged as a probe and dropped.
> 
> Source address selection is a rather complex topic, and
> here we are definitely purposefully using the source
> address selected by the routing lookup for the reply.

-- 
Bill Davidsen <davidsen@....com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html