netdev - Re: [PATCH 1/2] IPoIB: Fix unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFA01CE194.AD0117AA-ON6525735B.0018086F-6525735B.001832DF@in.ibm.com>
Date:	Wed, 19 Sep 2007 09:54:18 +0530
From:	Krishna Kumar2 <krkumar2@...ibm.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	davem@...emloft.net, general@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] IPoIB: Fix unregister_netdev hang

Hi Roland,

> Please double check your tree.  I just very carefully looked at my
> trees, and the poll_more: label is added in commit 6b460a71 ("[NET]:
> Make NAPI polling independent of struct net_device objects.") which is
> only in the net-2.6.24 tree.  Of course Dave did not change the
> version information in the Makefile since he wouldn't want Linus to
> pick up any extra strange changes when he pulls, so a net-2.6.24 tree
> will look like 2.6.23-rc6 as you quoted.
>
> And the refcounting bug I fixed is only in net-2.6.24.

You are absolutely right. My wording was incorrect, I should have said
net-2.6.24 (which is *at* rev rc6).

>  > To be clear, netif_rx_schedule while we are still in the poll list
will not
>  > do any harm as it does nothing since NAPI_STATE_SCHED is still set
(cleared
>  > by netif_rx_complete which has not yet run). Effectively we
lost/delayed
>  > processing an interrupt, if I understood the code right.
>
> Right, we lose an interrupt, and since the CQ events are one-shot, we
> never get another one, and the interface is effectively dead.

Thanks,

- KK

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html