netdev - Re: [PATCH]: Preliminary release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46F1A499.5060809@garzik.org>
Date:	Wed, 19 Sep 2007 18:37:13 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	David Miller <davem@...emloft.net>
CC:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	Ariel.Hendel@....com, greg.onufer@....com
Subject: Re: [PATCH]: Preliminary release of Sun Neptune driver

David Miller wrote:
> From: Jeff Garzik <jeff@...zik.org>
> Date: Wed, 19 Sep 2007 18:05:25 -0400
> 
>> That said, the 2-arg macro arg order is wrong.  It should be (reg,val) 
>> like tg3 and other drivers.
> 
> I actually wanted to mirror the ordering that
> writel() uses.
> 
> So the choice is arbitrary, either be consistent with
> our well established asm/io.h interfaces or a bunch
> of network driver :-)

IMO (val,reg) was always unnatural.  From looking at the register 
read/write interfaces people continually reinvent, humans definitely 
lean towards (reg,val).

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html