[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46F0E145.4020501@katalix.com>
Date: Wed, 19 Sep 2007 09:43:49 +0100
From: James Chapman <jchapman@...alix.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: "David S. Miller" <davem@...emloft.net>,
Michal Ostrowski <mostrows@...akeasy.net>,
Paul Mackerras <paulus@...ba.org>,
Toralf Förster <toralf.foerster@....de>,
netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit
Herbert Xu wrote:
> On Tue, Sep 18, 2007 at 09:19:33PM +0100, James Chapman wrote:
>> This one causes my test system to lock up. I'll investigate. Please
>> don't apply this patch for now.
>
> Sorry, I added a double-free on the skb after ip_queue_xmit.
> Please try this one instead.
>
> - /* Free the original skb */
> - kfree_skb(skb);
> -
> return 1;
>
> -discard:
> - /* Free the new skb. Caller will free original skb. */
> - if (skb2 != skb)
> - kfree_skb(skb2);
> abort:
> - return 0;
> + /* Free the original skb */
> + kfree_skb(skb);
> + return 1;
> }
Shouldn't this return 0 in the error case and without the kfree_skb()?
This lets ppp requeue the skb.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists