netdev - Re: [RESEND][PATCH 2/4 Rev-3] Add new timeval_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 19 Sep 2007 08:29:24 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kaber@...sh.net,
	socketcan@...tkopp.net, krkumar2@...ibm.com, tgraf@...g.ch,
	varuncha@...ibm.com
Subject: Re: [RESEND][PATCH 2/4 Rev-3] Add new timeval_to_sec function

On Wed, 19 Sep 2007 09:24:07 +0530
Varun Chandramohan <varunc@...ux.vnet.ibm.com> wrote:

> A new function for converting timeval to time_t is added in netlink.h. Its a common function used in differentplaces. The reason for adding this function in netlink.h is that its used by netlink for stats purpose.
> 
> Signed-off-by: Varun Chandramohan <varunc@...ux.vnet.ibm.com>
> ---
>  include/net/netlink.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/netlink.h b/include/net/netlink.h
> index d7b824b..f86cc59 100644
> --- a/include/net/netlink.h
> +++ b/include/net/netlink.h
> @@ -1100,4 +1100,17 @@ static inline int nla_validate_nested(st
>  #define nla_for_each_nested(pos, nla, rem) \
>  	nla_for_each_attr(pos, nla_data(nla), nla_len(nla), rem)
>  
> +/**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv:         pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + * Note : Here we round up the value. We dont need accuracy.
> + * This is mainly used in netlink for stats purpose.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> +	return (tv->tv_sec + (tv->tv_usec ? 1 : 0));
> +}
> +
>  #endif

1. If needed it belongs in include/linux/time.h

2. You never adequately explained why the function rounds up? No other
   statistical or time interface does rounding, why should this API round
   and others do not?

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html