netdev - Re: new NAPI interface broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200709191743.51917.ossthema@de.ibm.com>
Date:	Wed, 19 Sep 2007 17:43:51 +0200
From:	Jan-Bernd Themann <ossthema@...ibm.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	David Miller <davem@...emloft.net>,
	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	themann@...ibm.com, raisch@...ibm.com
Subject: Re: new NAPI interface broken

On Wednesday 19 September 2007 17:33, Roland Dreier wrote:
>  > One other thing I observed is that I can not unload the module as the
>  > ref counter of the eth device is too low. I haven't tracked down the 
>  > source of this problem yet.
> 
> I suspect that this is because netif_rx_reschedule() was missing a
> dev_hold() to match the dev_put() in netif_rx_complete().  Dave merged
> a fix for that problem yesterday, so current net-2.6.24 should be OK.
> Let us know if it's not OK, because then there's another bug...
> 
>  - R.
> 

When I applied this netif_rx_reschedule fix this problem did not occur
anymore (module could be unloaded). So I guess I hit the problem you
described.

Thanks,
Jan-Bernd
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html