netdev - Re: [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070920.112912.04442227.davem@davemloft.net>
Date:	Thu, 20 Sep 2007 11:29:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the
 highest skb

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Thu, 20 Sep 2007 15:17:44 +0300

> In general, it should not be necessary to call tcp_fragment for
> already SACKed skbs, but it's better to be safe than sorry. And
> indeed, it can be called from sacktag when a DSACK arrives or
> some ACK (with SACK) reordering occurs (sacktag could be made
> to avoid the call in the latter case though I'm not sure if it's
> worth of the trouble and added complexity to cover such marginal
> case).
> 
> The collapse case has return for SACKED_ACKED case earlier, so
> just WARN_ON if internal inconsistency is detected for some
> reason.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks Ilpo.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html