netdev - [PATCH] E1000: Do not allow requeue of freed skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 21 Sep 2007 10:30:43 +0530
From:	Krishna Kumar <krkumar2@...ibm.com>
To:	auke-jan.h.kok@...el.com
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Krishna Kumar <krkumar2@...ibm.com>
Subject: [PATCH] E1000: Do not allow requeue of freed skb

Returning BUSY will make qdisc_restart enqueue the skb which was already
freed. The bad skb was correctly freed and we should return NETDEV_TX_OK.

Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
---
diff -ruNp a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
--- a/drivers/net/e1000e/netdev.c	2007-09-21 10:23:29.000000000 +0530
+++ b/drivers/net/e1000e/netdev.c	2007-09-21 10:24:20.000000000 +0530
@@ -3531,7 +3531,7 @@ static int e1000_xmit_frame(struct sk_bu
 		/* handle pci_map_single() error in e1000_tx_map */
 		dev_kfree_skb_any(skb);
 		spin_unlock_irqrestore(&adapter->tx_queue_lock, irq_flags);
-		return NETDEV_TX_BUSY;
+		return NETDEV_TX_OK;
 	}
 
 	e1000_tx_queue(adapter, tx_flags, count);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html