netdev - Re: change the way e1000 is handling short VLAN frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1190410585.4231.46.camel@localhost>
Date:	Fri, 21 Sep 2007 17:36:25 -0400
From:	jamal <hadi@...erus.ca>
To:	Chris Leech <chris.leech@...il.com>
Cc:	Ben Greear <greearb@...delatech.com>,
	Emil Micek <emil.micek@...jasek.cz>,
	"auke-jan.h.kok@...el.com" <auke-jan.h.kok@...el.com>,
	netdev mailing list <netdev@...r.kernel.org>,
	Jesse <jesse.brandeburg@...el.com>
Subject: Re: change the way e1000 is handling short VLAN frames

On Fri, 2007-21-09 at 14:27 -0700, Chris Leech wrote:

> 
> Inserting the VLAN tag in software will not change the behavior in the
> way you want anyway, short frames will still be padded to 64 bytes.
> You'd have to do short packet padding in software to 68 bytes.  Or do
> software padding to 64 bytes and let the hardware insert the VLAN tag
> after.

I like the second one because it could be done totaly in the driver and
would resolve the problem IMO. All we need after is an ethtool knob to
select between 64B or 68B txmit.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html