lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 22 Sep 2007 12:53:04 +0200
From:	Patrick McHardy <>
To:	Urs Thuermann <>
CC:, David Miller <>,
	Thomas Gleixner <>,
	Oliver Hartkopp <>,
	Oliver Hartkopp <>
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module

Urs Thuermann wrote:
> Patrick McHardy <> writes:
>>You drop the module reference again when leaving this function.
>>So sock->ops might contain a stale pointer if the module is
>>unloaded after this. You need to either keep the module reference
>>while the socket is alive or remove stale references when
>>unregistering the protocol.
> I don't think that can happen.  Before we drop the module reference we
> call sk_alloc() which gets another module reference via its cp->prot
> argument.  If sk_alloc() fails we return with error from can_create()
> I assume sock->ops won't be used after that.

You're right, that should be enough.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists