netdev - Re: pktgen question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Sep 2007 10:00:58 -0500
From:	Steve Wise <swise@...ngridcomputing.com>
To:	Ben Greear <greearb@...delatech.com>
CC:	hadi@...erus.ca, Evgeniy Polyakov <johnpol@....mipt.ru>,
	netdev@...r.kernel.org, Robert Olsson <Robert.Olsson@...a.slu.se>
Subject: Re: pktgen question

Ben Greear wrote:
> Steve Wise wrote:
>> I think pktgen should be cloning the skbs using skb_clone().  Then it 
>> will work for all devices, eh?
> That might work, but it would decrease performance slightly (or, 
> increase CPU load at least).

Perf-wise, you could clone the skbs up front, then deliver them to the 
nic in a tight loop.  This would mitigate the added overhead introduced 
by calling skb_clone() in the loop doing transmits...

> 
> Maybe a new option:  multi_clone
> 

If the current code is busted, I think it should be fixed.

My 2 cents.

Steve.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html