netdev - Re: pktgen question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070924.104016.74732763.davem@davemloft.net>
Date:	Mon, 24 Sep 2007 10:40:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	swise@...ngridcomputing.com
Cc:	greearb@...delatech.com, hadi@...erus.ca, johnpol@....mipt.ru,
	netdev@...r.kernel.org, Robert.Olsson@...a.slu.se
Subject: Re: pktgen question

From: Steve Wise <swise@...ngridcomputing.com>
Date: Mon, 24 Sep 2007 08:54:13 -0500

> I think pktgen should be cloning the skbs using skb_clone().  Then it 
> will work for all devices, eh?

The problem is that skb_clone() is (relatively) expensive and
pktgen is trying to just grab a reference to the SKB in
the absolutely cheapest way possible.

In my personal opinion, I think what the drivers that don't
work with pktgen are doing is wrong and they should find
another way to pass state around other than to depend upon
being able to use the ->cb[] area at-will.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html