netdev - Re: [PATCH 2/7] CAN: Add PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070925083303.6c1f7701@freepuppy.rosehill>
Date:	Tue, 25 Sep 2007 08:33:03 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Urs Thuermann <urs@...ogud.escape.de>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Joe Perches <joe@...ches.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Oliver Hartkopp <oliver@...tkopp.net>,
	Oliver Hartkopp <oliver.hartkopp@...kswagen.de>
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module

On 25 Sep 2007 15:24:33 +0200
Urs Thuermann <urs@...ogud.escape.de> wrote:

> Arnaldo Carvalho de Melo <acme@...stprotocols.net> writes:
> 
> > > +	skb_queue_purge(&sk->sk_receive_queue);
> > > +	if (sk->sk_protinfo)
> > > +		kfree(sk->sk_protinfo);
> > > +}
> > 
> > Is it really needed to do this sk_protinfo check?
> 
> Thanks for finding this.  This is from 2.6.12 times or so.  We have
> other CAN protocol (which we are not allowed to put under GPL)
> implemenatations which still use the protinfo field.  But we should
> change those and I will delete this check.
> 
> urs

Then please make all exported symbols marked EXPORT_SYMBOL_GPL to make
sure that the other CAN protocol can not reuse your infrastructure.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html