netdev - Re: [PATCH] netns: Simplify the network namespace list locking rules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46FB3DF4.10309@sw.ru>
Date:	Thu, 27 Sep 2007 09:21:56 +0400
From:	"Denis V. Lunev" <den@...ru>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	David Miller <davem@...emloft.net>,
	Daniel Lezcano <dlezcano@...ibm.com>,
	Benjamin Thery <benjamin.thery@...l.net>,
	Kirill Korotaev <dev@...ru>,
	Linux Containers <containers@...ts.osdl.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] netns:  Simplify the network namespace list locking rules.

Eric W. Biederman wrote:
> Denis V. Lunev <den@...ru> noticed that the locking rules
> for the network namespace list are over complicated and broken.
> 
> In particular the current register_netdev_notifier currently
> does not take any lock making the for_each_net iteration racy
> with network namespace creation and destruction. Oops.
> 
> The fact that we need to use for_each_net in rtnl_unlock() when
> the rtnetlink support becomes per network namespace makes designing
> the proper locking tricky.  In addition we need to be able to call
> rtnl_lock() and rtnl_unlock() when we have the net_mutex held.
> 
> After thinking about it and looking at the alternatives carefully
> it looks like the simplest and most maintainable solution is
> to remove net_list_mutex altogether, and to use the rtnl_mutex instead.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
Acked-by: Denis V. Lunev <den@...nvz.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html