netdev - Re: Null dereference in socket.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070928.160057.132434706.davem@davemloft.net>
Date:	Fri, 28 Sep 2007 16:00:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cebbert@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: Null dereference in socket.c

From: Chuck Ebbert <cebbert@...hat.com>
Date: Fri, 28 Sep 2007 18:58:36 -0400

> After debugging an oops (https://bugzilla.redhat.com/attachment.cgi?id=209231)
> I find it happens here in socket.c::sock_ioctl() line 902:
> 
>                default:
> =============>          err = sock->ops->ioctl(sock, cmd, arg);
> 
>                         /*
>                          * If this ioctl is unknown try to hand it down
>                          * to the NIC driver.
>                          */
>                         if (err == -ENOIOCTLCMD)
>                                 err = dev_ioctl(cmd, argp);
>                         break;
> 
> 
> ioctl is NULL and the kernel jumps to address 0. Should we add a check
> for that?
> 
> Bug report:
> https://bugzilla.redhat.com/show_bug.cgi?id=306801

Every protocol should provide a non-NULL ->ioctl() method,
find out which one isn't and fix it.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html