netdev - Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46FC76DA.6030906@garzik.org>
Date:	Thu, 27 Sep 2007 23:36:58 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	unlisted-recipients:; (no To-header on input)
CC:	Zang Roy-r61911 <tie-fei.zang@...escale.com>,
	Andrew Morton <akpm@...l.org>, netdev <netdev@...r.kernel.org>,
	Kyle McMartin <kyle@...artin.ca>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet
 driver

Zang Roy-r61911 wrote:
> From: Roy Zang <tie-fei.zang@...escale.com>
> 
> Clean up redundant PHY write line for ULi526x Ethernet
> Driver.
> 
> Signed-off-by: Roy Zang <tie-fei.zang@...escale.com>
> ---
>  drivers/net/tulip/uli526x.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
> index ca2548e..53a8e65 100644
> --- a/drivers/net/tulip/uli526x.c
> +++ b/drivers/net/tulip/uli526x.c
> @@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
>  			case ULI526X_100MFD: phy_reg = 0x2100; break;
>  			}
>  			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
> -       			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);

Kyle and Grant, I'll queue this up, unless ya'll object...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html