[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070928081918.GB2304@2ka.mipt.ru>
Date: Fri, 28 Sep 2007 12:19:19 +0400
From: Evgeniy Polyakov <johnpol@....mipt.ru>
To: David Miller <davem@...emloft.net>
Cc: kaber@...sh.net, herbert@...dor.apana.org.au,
netdev@...r.kernel.org, kuznet@....inr.ac.ru, hadi@...erus.ca
Subject: Re: [PKT_SCHED]: Add stateless NAT
On Thu, Sep 27, 2007 at 12:52:39PM -0700, David Miller (davem@...emloft.net) wrote:
> From: Patrick McHardy <kaber@...sh.net>
> Date: Thu, 27 Sep 2007 15:39:34 +0200
>
> > Evgeniy Polyakov wrote:
> > > On Thu, Sep 27, 2007 at 09:20:37PM +0800, Herbert Xu (herbert@...dor.apana.org.au) wrote:
> > >
> > >>How about putting it in net/core/utils.c?
> > >
> > >
> > > I knew, that was a bad idea to try to fix netfilter dependency :)
> > >
> > > diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h
> >
> >
> > This looks good to me.
>
> I still think the nf_*() prefixes should all go and the extern
> prototypes should go into an independant header file.
>
> These are not netfilter routines, they are "INET" helpers.
>
> And we should make similar treatment for all of the ipv6
> packet parser helper functions that ipv6 netfilter needs.
Should netfilter still have own nf_ prefixed functions which will just
call the same ones without prefix from inet header?
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists