netdev - Re: [PATCH][MIPS][7/7] AR7: ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46FDE507.90206@pobox.com>
Date:	Sat, 29 Sep 2007 01:39:19 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Matteo Croce <technoboy85@...il.com>
CC:	linux-mips@...ux-mips.org, Eugene Konev <ejka@...i.kspu.ru>,
	netdev@...r.kernel.org, davem@...emloft.net, kuznet@....inr.ac.ru,
	pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...eworks.de, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet

Overall, looks pretty clean, good job!

Comments:

1) [major issue] Don't take and release a heavy lock on every single RX 
packet.

2) remove net_device_stats from private structure, and use net_device::stats

3) rx_ring_size should not be a module param, since that should be 
supported via ethtool

4) cpmac_tx_timeout() doesn't really do anything to alleviate the condition

5) don't set dev->mem_start and dev->mem_end, those are fields that are 
going away, and that's not their intended purpose.  just store a pointer 
to the resource info.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html