netdev - Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Oct 2007 13:36:24 -0400
From:	Brian Haley <brian.haley@...com>
To:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
Cc:	brian.haley@...com, dlstevens@...ibm.com, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

Hi,

YOSHIFUJI Hideaki / 吉藤英明 wrote:
>>>         I think it'd also be better if you add the check to be:
>>>
>>>         if (ipv6_addr_type(target) & 
>>> (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_UNICAST))
>>>
>>> or something along those lines, rather than reproducing ipv6_addr_type() 
>>> code
>>> separately in a new ipv6_addr_linklocal() function.
> 
> I'm fine with the idea of the fix itself.

Ok, in both the receive and send code?

> Please use ipv6_addr_type() so far and convert other users as well
> to ipv6_addr_linklocal() in another patch.

I'll re-do the patch.

-Brian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html