lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Oct 2007 13:47:04 -0700 From: Corey Hickey <bugfood-ml@...ooh.org> To: Patrick McHardy <kaber@...sh.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH 05/10] Add divisor. Patrick McHardy wrote: > Corey Hickey wrote: >> Make hash divisor user-configurable. >> > >> @@ -120,7 +121,7 @@ static __inline__ unsigned sfq_fold_hash(struct sfq_sched_data *q, u32 h, u32 h1 >> /* Have we any rotation primitives? If not, WHY? */ >> h ^= (h1<<pert) ^ (h1>>(0x1F - pert)); >> h ^= h>>10; >> - return h & 0x3FF; >> + return h & (q->hash_divisor-1); > > > This assumes that hash_divisor is a power of two, but this is > not enforced anywhere. Ok. I'll move that part from userspace to the kernel. That should be better anyway. -Corey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists