lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Oct 2007 15:20:00 -0600 From: Grant Grundler <grundler@...isc-linux.org> To: akpm@...ux-foundation.org Cc: jeff@...zik.org, netdev@...r.kernel.org, micah.gruber@...il.com, grundler@...isc-linux.org, kyle@...artin.ca Subject: Re: [patch 06/13] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c On Tue, Oct 02, 2007 at 02:11:38PM -0700, akpm@...ux-foundation.org wrote: > From: Micah Gruber <micah.gruber@...il.com> > > This patch fixes an apparent potential null dereference bug where we > dereference dev before a null check. This patch simply remvoes the > can't-happen test for a null pointer. > > Signed-off-by: Micah Gruber <micah.gruber@...il.com> > Cc: Grant Grundler <grundler@...isc-linux.org> Acked-by: Grant Grundler <grundler@...isc-linux.org> thanks! grant > Acked-by: Jeff Garzik <jeff@...zik.org> > Acked-by: Kyle McMartin <kyle@...artin.ca> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> > --- > > drivers/net/tulip/uli526x.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff -puN drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt drivers/net/tulip/uli526x.c > --- a/drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt > +++ a/drivers/net/tulip/uli526x.c > @@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int > unsigned long ioaddr = dev->base_addr; > unsigned long flags; > > - if (!dev) { > - ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0); > - return IRQ_NONE; > - } > - > spin_lock_irqsave(&db->lock, flags); > outl(0, ioaddr + DCR7); > > _ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists