netdev - Re: [patch 09/13] forcedeth: "no link" is informational

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071002144924.2055022d@freepuppy.rosehill>
Date:	Tue, 2 Oct 2007 14:49:24 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	akpm@...ux-foundation.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, akpm@...ux-foundation.org,
	eswierk@...stra.com, aabdulla@...dia.com
Subject: Re: [patch 09/13] forcedeth: "no link" is informational

On Tue, 02 Oct 2007 14:11:41 -0700
akpm@...ux-foundation.org wrote:

> From: "Ed Swierk" <eswierk@...stra.com>
> 
> Log "no link during initialization" at KERN_INFO as it's not an error, and
> occurs every time the interface comes up (when the forcedeth-phy-power-down
> patch is applied).
> 
> Signed-off-by: Ed Swierk <eswierk@...stra.com>
> Cc: Ayaz Abdulla <aabdulla@...dia.com>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/forcedeth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/forcedeth.c~forcedeth-no-link-is-informational drivers/net/forcedeth.c
> --- a/drivers/net/forcedeth.c~forcedeth-no-link-is-informational
> +++ a/drivers/net/forcedeth.c
> @@ -4921,7 +4921,7 @@ static int nv_open(struct net_device *de
>  	if (ret) {
>  		netif_carrier_on(dev);
>  	} else {
> -		printk("%s: no link during initialization.\n", dev->name);
> +		printk(KERN_INFO "%s: no link during initialization.\n", dev->name);
>  		netif_carrier_off(dev);
>  	}
>  	if (oom)

Driver should use netif_msg_link_up()


-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html