netdev - Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710041034.48533.flamingice@sourmilk.net>
Date:	Thu, 4 Oct 2007 10:34:43 -0400
From:	Michael Wu <flamingice@...rmilk.net>
To:	Daniel Drake <dsd@...too.org>
Cc:	linville@...driver.com, johannes@...solutions.net,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

On Thursday 04 October 2007 07:33, Daniel Drake wrote:
> Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit.
> It will then be reinitialised to the default (ieee80211_subif_start_xmit)
> in ieee80211_if_set_type.
>
Well.. this kinda sucks, but we can clean up the logic here later.

> +	BUG_ON(netif_running(dev));
This will never happen, so there's no point.

ACK with that bit removed.

Thanks,
-Michael Wu

Content of type "application/pgp-signature" skipped