lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 04 Oct 2007 16:53:41 +0200 From: Cedric Le Goater <clg@...ibm.com> To: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> CC: David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-2.6.24 0/3]: More TCP fixes Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Cedric Le Goater wrote: > >> Cedric Le Goater wrote: >>> Below are the messages I got on 2) right after running ketchup (which does >>> a wget www.kernel.org) > > Oops, those tcp_fragment WARNINGs in the other mail were due to bug in > the debug patch as it called verify too early in there (before queue was > adjusted, no wonder it finds state inconsistent at that point, fixed that)... > > ...So please discard all old debug patches, they're all broken in this > respect... :-( > >>> not a warning on 1) with your extra verbose patch. >> bummer, I got this one on 1) :( >> >> WARNING: at /home/legoater/linux/net-2.6.24.git/net/ipv4/tcp_input.c:2325 tcp_fastretrans_alert() >> Call Trace: >> <IRQ> [<ffffffff8022ddb6>] __wake_up+0x1f/0x4c >> [<ffffffff803fd9d3>] tcp_ack+0xcee/0x18ac >> [<ffffffff80400764>] tcp_rcv_established+0x61f/0x6df > > ...I just wonder why that's the first place where it occurs... Can you try > the debug patch below (fixed verify place in tcp_fragment/collapse, added > some of them to narrow it down, and handled GSO more user friendly way in > the printout). Put it on top of those three patches (mm should be fine :-)). > ...I wish the verify triggers way before the fastretrans trap (for some > reason it didn't do that in the quoted trace, maybe I had some verifys > missing in that old patch or something)... so here are the results on a net-2.6.24 kernel. I've put the patchset here to make sure it's correct: http://legoater.free.fr/patches/2.6.23/net-2.6.24.git-tcp_fastretrans/ and plenty of logs : http://legoater.free.fr/patches/2.6.23/net-2.6.24.git-tcp_fastretrans.messages FYI, config is here : http://legoater.free.fr/patches/2.6.23/net-2.6.24.git-tcp_fastretrans.config C. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists