netdev - Re: net-2.6.24 compile breakage: error: 'ipgre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071004.151108.82373575.davem@davemloft.net>
Date:	Thu, 04 Oct 2007 15:11:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	auke-jan.h.kok@...el.com
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org
Subject: Re: net-2.6.24 compile breakage: error: 'ipgre_header' undeclared

From: "Kok, Auke" <auke-jan.h.kok@...el.com>
Date: Thu, 04 Oct 2007 14:49:10 -0700

> I'm getting this on net-2.6.24 today:
> 
>   CC [M]  net/ipv4/ip_gre.o
> net/ipv4/ip_gre.c:1135: error: 'ipgre_header' undeclared here (not in a function)
> make[2]: *** [net/ipv4/ip_gre.o] Error 1
> make[1]: *** [net/ipv4] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 
> 
> the git log says sch touched it last:

Please us Stephen's current email address if you really want to reach
him :) It was even mentioned in the commit sign off.  I've fixed it up
in the CC:

>     [NET]: Move hardware header operations out of netdevice.
> 
>     Since hardware header operations are part of the protocol class
>     not the device instance, make them into a separate object and
>     save memory.
> 
>     Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
>     Signed-off-by: David S. Miller <davem@...emloft.net>

Stephen, we need to handle the case where NET_IPGRE_BROADCAST is
not enabled.  ipgre_header() is only compiled in when that is
set, but you reference it unconditionally.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html