| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071004221358.GM6037@tuxdriver.com> Date: Thu, 4 Oct 2007 18:13:58 -0400 From: "John W. Linville" <linville@...driver.com> To: Roland Dreier <rdreier@...co.com> Cc: Michael Wu <flamingice@...rmilk.net>, Michael Buesch <mb@...sch.de>, Daniel Drake <dsd@...too.org>, johannes@...solutions.net, netdev@...r.kernel.org, linux-wireless@...r.kernel.org Subject: Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed On Thu, Oct 04, 2007 at 02:31:26PM -0700, Roland Dreier wrote: > > Programming with assertions (and BUG_ON is a form of that) is > > generally a good practice. Almost any book or other source on > The problem with BUG_ON is that it kills the whole system. So every > time you add a BUG_ON into code, you have to weigh whether the problem > you detected is so severe that the right response is to panic. For > example, I can see panicking on something fundamental like corrupted > page tables. However I would submit that the wireless stack should > *never* use BUG_ON -- printing a warning and trying to limp on seems > preferable to me. OK, I'll buy that as an argument to use WARN_ON instead of BUG_ON. But it doesn't invalidate the desire to have some sort of assertion. John -- John W. Linville linville@...driver.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists