netdev - Re: [PATCH]: Third (final?) release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4706C98F.1060601@garzik.org>
Date:	Fri, 05 Oct 2007 19:32:31 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	David Miller <davem@...emloft.net>
CC:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	Ariel.Hendel@....com, greg.onufer@....com,
	Ashley.Saulsbury@....com, Matheos.Worku@....com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

David Miller wrote:
> From: Stephen Hemminger <shemminger@...ux-foundation.org>
> Date: Fri, 5 Oct 2007 08:35:56 -0700
> 
>>> +static void niu_log_rxchan_errors(struct niu *np, struct rx_ring_info *rp,
>>> +				  u64 stat)
>>> +{
>>> +	printk(KERN_ERR PFX "%s: RX channel %u errors ( ",
>>> +	       np->dev->name, rp->rx_channel);
>> dev_err??
> 
> I've made conversions over to dev_err() where possible.
> 
> Thanks!
> 
>>>From cbc4b58382eab08aa231f23d21839c011b4c9f8c Mon Sep 17 00:00:00 2001
> From: David S. Miller <davem@...set.davemloft.net>
> Date: Fri, 5 Oct 2007 16:22:39 -0700
> Subject: [PATCH] [NIU]: Use dev_err().
> 
> Suggested by Stephen Hemminger.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

It seems you made redundant 1/2 of the comment I just sent :)

ACK


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html