netdev - Re: [PATCH net-2.6.24] s2io: sparse warnings fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470679B7.2060901@pobox.com>
Date:	Fri, 05 Oct 2007 13:51:51 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Ramkrishna Vepa <ram.vepa@...erion.com>,
	Raapur Santosh <santosh.rastapur@...erion.com>,
	Sivakumar Subramani <sivakumar.subramani@...erion.com>,
	Sreenivasa Honnur <sreenivasa.honnur@...erion.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.24] s2io: sparse warnings fix

Stephen Hemminger wrote:
> Fix warnings from sparse checker about shadowed definition and improperly
> formatted ethtool_strings.
> 
> I chose to change module parameter rather than uglify the code by changing
> the variable name.

Changing the name of existing module parameters can potentially 
introduce breakage in the field.

Additionally, we have module_param_named() to account for this sort of 
thing, where the module parameter name differs from the internal 
variable name.

The rest looks OK.

Please resend, potentially moving the module parameter change(s) into a 
separate patch.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html