netdev - Re: [PATCH]: Third (final?) release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071005.141809.55498410.davem@davemloft.net>
Date:	Fri, 05 Oct 2007 14:18:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	netdev@...eo.de
Cc:	netdev@...r.kernel.org, Ariel.Hendel@....com, greg.onufer@....com,
	jeff@...zik.org, Ashley.Saulsbury@....com, Matheos.Worku@....com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

From: Ingo Oeser <netdev@...eo.de>
Date: Fri, 5 Oct 2007 18:46:19 +0200

> Could this driver be split into more files. 8k lines per file
> is quite a lot. Although GCC might optimize it best this way :-)

Absolutely not!!!!!!!

I hate multiple file drivers, with a passion, they absolutely and
positivel suck.  I cringe every time I have to study a driver that
is broken up into multiple files.

They are a nightmare to hack on.  You have to keep typing in grep
commands, be a cscope wizard, or whatever to search around and find
the file in which the function or variable you want to learn about.

If it's all in one file, you can just sit in your single editor
buffer and get a lot of work done.

And to top it off such multi-file drivers tend to be a lot larger
and thus even harder to understand.

Multi-file drivers, just say no.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html