netdev - Re: [PATCH]: Third (final?) release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071005.170428.68050176.davem@davemloft.net>
Date:	Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	netdev@...r.kernel.org, Ariel.Hendel@....com, greg.onufer@....com,
	jeff@...zik.org, Ashley.Saulsbury@....com, Matheos.Worku@....com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Fri, 5 Oct 2007 08:43:17 -0700

> Sparse warnings from new driver.
>  CHECK   drivers/net/niu.c
> drivers/net/niu.c:619:7: warning: symbol 'err' shadows an earlier one
> drivers/net/niu.c:574:6: originally declared here
> drivers/net/niu.c:4673:7: warning: symbol 'err' shadows an earlier one
> drivers/net/niu.c:4668:12: originally declared here

I fixed these two, the first was harmless but the second
one would cause error cases to return the wrong error
status to the caller.

> drivers/net/niu.c:203:2: error: bad constant expression
> drivers/net/niu.c:203:2: error: cannot size expression
> drivers/net/niu.c:4214:2: error: bad constant expression
> drivers/net/niu.c:4214:2: error: cannot size expression

I can't figure out what sparse doesn't like here.

Thanks.

>From 81d1d30537ae388a9ee385d0640999195967b905 Mon Sep 17 00:00:00 2001
From: David S. Miller <davem@...set.davemloft.net>
Date: Fri, 5 Oct 2007 17:03:19 -0700
Subject: [PATCH] [NIU]: Fix shadowed local variables.

Noticed by sparse.

Signed-off-by: David S. Miller <davem@...emloft.net>
---
 drivers/net/niu.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index da15a91..64b988b 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -607,7 +607,6 @@ static int serdes_init_10g(struct niu *np)
 
 	for (i = 0; i < 4; i++) {
 		u32 rxtx_ctrl, glue0;
-		int err;
 
 		err = esr_read_rxtx_ctrl(np, i, &rxtx_ctrl);
 		if (err)
@@ -4657,7 +4656,6 @@ static int niu_request_irq(struct niu *np)
 	err = 0;
 	for (i = 0; i < np->num_ldg; i++) {
 		struct niu_ldg *lp = &np->ldg[i];
-		int err;
 
 		err = request_irq(lp->irq, niu_interrupt,
 				  IRQF_SHARED | IRQF_SAMPLE_RANDOM,
-- 
1.5.3.3

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html