lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <86802c440710061043u6e51cd7q468346bd06b08657@mail.gmail.com> Date: Sat, 6 Oct 2007 10:43:30 -0700 From: "Yinghai Lu" <yhlu.kernel@...il.com> To: "Jeff Garzik" <jgarzik@...ox.com> Cc: "Ayaz Abdulla" <aabdulla@...dia.com>, "Manfred Spraul" <manfred@...orfullife.com>, nedev <netdev@...r.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>, "David Miller" <davem@...emloft.net>, "Andrew Morton" <akpm@...ux-foundation.org> Subject: Re: MSI interrupts and disable_irq On 9/28/07, Jeff Garzik <jgarzik@...ox.com> wrote: > Ayaz Abdulla wrote: > > I am trying to track down a forcedeth driver issue described by bug 9047 > > in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). > > I added a patch to synchronize the timer handlers so that one handler > > doesn't accidently enable the IRQ while another timer handler is running > > (see attachment 'Add timer lock' in bug report) and for other processing > > protection. > > > > However, the system still had an Oops. So I added a lock around the > > nv_rx_process_optimized() and the Oops has not happened (see attachment > > 'New patch for locking' in bug report). This would imply a > > synchronization issue. However, the only callers of that function are > > the IRQ handler and the timer handlers (in non-NAPI case). The timer > > handlers use disable_irq so that the IRQ handler does not contend with > > them. It looks as if disable_irq is not working properly. > > > > This issue repros only with MSI interrupt and not legacy INTx > > interrupts. Any ideas? > > (added linux-kernel to CC, since I think it's more of a general kernel > issue) > I wonder if the race is between soft_timer for nv_do_nic_poll from different CPUs YH - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists