netdev - Re: [PATCH]: Third (final?) release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071005172801.7f657e81@freepuppy.rosehill>
Date:	Fri, 5 Oct 2007 17:28:01 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, Ariel.Hendel@....com, greg.onufer@....com,
	jeff@...zik.org, Ashley.Saulsbury@....com, Matheos.Worku@....com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

On Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <shemminger@...ux-foundation.org>
> Date: Fri, 5 Oct 2007 08:43:17 -0700
> 
> > Sparse warnings from new driver.
> >  CHECK   drivers/net/niu.c
> > drivers/net/niu.c:619:7: warning: symbol 'err' shadows an earlier one
> > drivers/net/niu.c:574:6: originally declared here
> > drivers/net/niu.c:4673:7: warning: symbol 'err' shadows an earlier one
> > drivers/net/niu.c:4668:12: originally declared here
> 
> I fixed these two, the first was harmless but the second
> one would cause error cases to return the wrong error
> status to the caller.
> 
> > drivers/net/niu.c:203:2: error: bad constant expression
> > drivers/net/niu.c:203:2: error: cannot size expression
> > drivers/net/niu.c:4214:2: error: bad constant expression
> > drivers/net/niu.c:4214:2: error: cannot size expression
> 
> I can't figure out what sparse doesn't like here.

Sparse doesn't like dynamically sized arrays, which is what BUILD_BUG_ON()
expands into.  Not sure why it is hostile to dynamic arrays,
probably just a Linus (or Viro) taste thing.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html