lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4708EFE0.1080900@garzik.org>
Date: Sun, 07 Oct 2007 10:40:32 -0400
From: Jeff Garzik <jeff@...zik.org>
To: netdev@...r.kernel.org, Ayaz Abdulla <aabdulla@...dia.com>
CC: LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 6/n] forcedeth: protect slow path with mutex
Jeff Garzik wrote:
> commit abca163a14b28c234df9bf38034bc967ff81c3aa
> Author: Jeff Garzik <jeff@...zik.org>
> Date: Sun Oct 7 07:22:14 2007 -0400
>
> [netdrvr] forcedeth: wrap slow path hw manipulation inside hw_mutex
>
> * This makes sure everybody who wants to start/stop the RX and TX engines
> first acquires this mutex.
>
> * tx_timeout code was deleted, replaced by scheduling reset_task.
>
> * linkchange moved to a workqueue (always inside hw_mutex)
>
> * simplified irq handling a bit
>
> * make sure to disable workqueues before NAPI
>
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>
> drivers/net/forcedeth.c | 272 ++++++++++++++++++++++++++++++------------------
> 1 file changed, 175 insertions(+), 97 deletions(-)
You will need the attached patch to even build (oops).
Also, testing shows there is a mutex deadlock somewhere.
View attachment "patch.fe6" of type "text/plain" (604 bytes)
Powered by blists - more mailing lists