netdev - Re: [PATCH net-2.6.24] net: sparse warning fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071007.235956.98531097.davem@davemloft.net>
Date:	Sun, 07 Oct 2007 23:59:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.24] net: sparse warning fixes

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Fri, 5 Oct 2007 17:14:07 -0700

> Fix a bunch of sparse warnings. Mostly about 0 used as
> NULL pointer, and shadowed variable declarations.
> 
> The two noteable changes are:
>  * hash size should have been unsigned
>  * cls_u32 had a case where error code wasn't been
>    propogated properly, so it could return 0 but still
>    have an error.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>

Applied, and I stuffed the cls_u32 fix into net-2.6 as well.

But please fix the following, this is the second time I've
had to remove this bit from one of your patches.

> @@ -6,7 +6,7 @@
>   *
>   * Alexey Kuznetsov  <kuznet@....inr.ac.ru>
>   * Ben Greear <greearb@...delatech.com>
> - * Jens Låås <jens.laas@...a.slu.se>
> + * Jens Låås <jens.laas@...a.slu.se>
>   *
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU General Public License

Please please please please, for the second time, fix the encoding
your editor uses when you save copies of this source file, this hunk
of your patches never applies cleanly.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html