netdev - Re: [PATCH] net/core: split dev_ifsioc() according to locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071008.000653.51864134.davem@davemloft.net>
Date:	Mon, 08 Oct 2007 00:06:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] net/core: split dev_ifsioc() according to locking

From: Arnd Bergmann <arnd@...db.de>
Date: Sun, 7 Oct 2007 02:17:08 +0200

> On Saturday 06 October 2007, Jeff Garzik wrote:
> > 
> > This always bugged me:  dev_ioctl() called dev_ifsioc() either inside
> > read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being
> > executed.
> > 
> > This change moves the ioctls executed inside dev_base_lock to a new
> > function, dev_ifsioc_locked().  Now the locking context is completely
> > clear to the reader.
> > 
> > Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> 
> Great idea!

I think so too, applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html