netdev - Re: [PATCH][TG3]Some cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1191850923.4352.50.camel@localhost>
Date:	Mon, 08 Oct 2007 09:42:03 -0400
From:	jamal <hadi@...erus.ca>
To:	David Miller <davem@...emloft.net>
Cc:	mchan@...adcom.com, mcarlson@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH][TG3]Some cleanups

On Sun, 2007-07-10 at 23:32 -0700, David Miller wrote:

> This "cleanup" only makes sense if we go with your TX batching
> interfaces.
>
> They make the TX batching support patch for this driver "nice" and
> "clean", but it makes zero sense in any other context.  
> In fact, it
> adds more memory references in the TX pacth, and in fact does so by
> adding usage of the skb->cb[] which the driver didn't need to do
> previously.
> 
> So I'm going to hold off on this one for now, keep it in your TX
> batching changes instead.

The batching benefits from it because it reuses code. But i would put
readability as something of no value. 
In any case i would defer this for later.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html