lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20071007.231608.104667710.davem@davemloft.net> Date: Sun, 07 Oct 2007 23:16:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeff@...zik.org Cc: dlunev@...il.com, netdev@...r.kernel.org, herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, den@...nvz.org Subject: Re: [NET] IPv6 oops bisected From: Jeff Garzik <jeff@...zik.org> Date: Sun, 07 Oct 2007 10:56:07 -0400 > /etc/sysconfig/network-scripts/network-functions-ipv6: line 246: 1760 Killed > LC_ALL=C /sbin/ip $options > > > NULL pointer dereference at 0x000003f8 > > backtrace: > :ipv6:ip6_route_add+0x1b1/0x543 'dev' can be NULL in that code branch of ip6_route_add(), yet we're deferencing it to get dev->nd_net. if ((cfg->fc_flags & RTF_REJECT) || (dev && (dev->flags&IFF_LOOPBACK) && !(addr_type&IPV6_ADDR_LOOPBACK))) { /* hold loopback dev/idev if we haven't done so. */ - if (dev != init_net.loopback_dev) { + if (dev != dev->nd_net->loopback_dev) { I'll add the appropriate check for NULL as follows: commit b3c1427c21f9bac4ceaa02e875f3b2c9a5592132 Author: David S. Miller <davem@...set.davemloft.net> Date: Sun Oct 7 23:15:56 2007 -0700 [IPV6]: Fix OOPS introduced by 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09. In ip6_add_route(), 'dev' can be NULL, so check that before we try to deref dev->nd_net. Based upon a crash report by Jeff Garzik. Signed-off-by: David S. Miller <davem@...emloft.net> diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1188,7 +1188,7 @@ int ip6_route_add(struct fib6_config *cfg) if ((cfg->fc_flags & RTF_REJECT) || (dev && (dev->flags&IFF_LOOPBACK) && !(addr_type&IPV6_ADDR_LOOPBACK))) { /* hold loopback dev/idev if we haven't done so. */ - if (dev != dev->nd_net->loopback_dev) { + if (!dev || (dev != dev->nd_net->loopback_dev)) { if (dev) { dev_put(dev); in6_dev_put(idev); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists