lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 08 Oct 2007 18:04:15 +0200 From: Oliver Hartkopp <oliver@...tkopp.net> To: David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver David Miller wrote: > if (err < 0) > - return err; > + goto out_err; > > if (err != (PHYXS_XGXS_LANE_STAT_ALINGED | > PHYXS_XGXS_LANE_STAT_MAGIC | > @@ -1133,6 +1133,10 @@ out: > > *link_up_p = link_up; > return 0; > + > +out_err: > + spin_unlock_irqrestore(&np->lock, flags); > + return err; > } > > static int link_status_1g(struct niu *np, int *link_up_p) > Should *link_up_p be set to any valid value in the out_err case in link_status_10g()? Oliver - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists